openkinome / kinoml

Structure-informed machine learning for kinase modeling
https://openkinome.org/kinoml/
MIT License
51 stars 21 forks source link

Structural API #20

Closed jaimergp closed 3 years ago

jaimergp commented 4 years ago

This is now the base PR for all the structural work done in the last weeks. This contains:

I have merged all PRs here and will work on getting them in shape for the library.

To do

schallerdavid commented 4 years ago

Awesome, thanks @jaimergp!

jaimergp commented 4 years ago

Please feel free to retag me when another review is needed!

schallerdavid commented 4 years ago

Hey @jaimergp,

welcome back! I hope you had nice holidays. Getting a review would be great.

schallerdavid commented 4 years ago

Hey @jaimergp,

I think I would be ready for a review.

The protein preparation pipeline in examples/kinase_modeling.ipynp does not completely work, but thats mainly due to OESpruce bugs mentioned in the notebook. Once those are fixed, the functions might actually work out. I found it quite hard to find a good location for very KLIFS and kinase specific functions, e.g. select_structure for selecting a kinase structure for docking a small molecule, so they might be a little missplaced.

There is also a notebook analyzing the kinase domain sequences retrieved from Uniprot (examples/kinase_domain_sequence.ipynb). I think you mentioned, you were doing similar work with a student. Could you point me to that repo?

Thanks, David

schallerdavid commented 3 years ago

Hey @jaimergp,

ready for review. I hope it's more readable now.

David

jaimergp commented 3 years ago

I am taking over! Please don't add more stuff now unless we have discussed it first!