Closed jaimergp closed 3 years ago
Cross-validation in Core functionality could be solved using skorch package. Check PR #27 for some toy example using skorch with observation model :)
A few aspects which still need to be addressed:
[x] When dealing with the XGBoost package, there should be a distinction between the observation model and the custom loss. See this notebook for more details.
For the full detailed explanation of the observation models, losses, custom losses, and associated differentiation (gradient and hessian), please refer to the overleaf document (maybe useful @jaimergp ).
[x] If we want to have a ligand-based only model, we can pass None
as a kinase featurizer. However, this will not reflect a real ligand-based model, since all the systems would be used in this case. We should instead create one single model for each of the kinases, meaning that if there are N unique kinases in a data set, N models have to trained. -> This will probably be addressed by looping over all kinases.
[x] Create toy example for dealing with multiple measurement types @t-kimber .
Outdated, will create new issues when needed.
This issue will track all the progress related to getting the core functionality for ligand-based models merged to
master
.Core functionality
Standard practices
mkdocs
forSphinx
+ material theme?Consolidate previous PRs
Pending scientific questions
[substrate]
: we could estimate by cross-validation, use relative pIC50s, or add that as a nuisance parameter in the future