Closed schallerdavid closed 3 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Hi @t-kimber and @jaimergp ,
I merged master
into this branch
. This branch
adds several improvements to the structural modeling pipeline and additionally adds tests. Pytest only reports a single failure, but this is intended since it is simply not implemented yet. My complex featurizers seem to work. Is there anything else I can test or you want to test before I merge this into master?
Cheers, David
"Pipeline" tests are done in https://github.com/openkinome/experiments-binding-affinity. Talia should be able to tell you how to add your featurizers to some examples there and run it locally!
Except for test_access_by_index_roundtrip
all tests are passing. But this is not implemented yet. The featurization tests in experiments-binding-affinity
are passing but not the model training. However, this was already the case with the current master (see #13). Merging now.
Description
This PR adds important updates, new functionalities and tests to the KinoML modeling pipeline.
Todos
Notable points that this PR has either accomplished or will accomplish.
Status