openkinome / kinoml

Structure-informed machine learning for kinase modeling

https://openkinome.org/kinoml/

MIT License

51 stars 21 forks source link

minor fix #42

Closed t-kimber closed 3 years ago

t-kimber commented 3 years ago

Description

Kinase-informed featurizer. Change shape output for the kinase hash so that the concatenation axis runs as for the kinase composition in the experiments repo.

Todos

[x] Change hash numpy shape from () to (1,)

Questions

The unit test runs without failing even with this edit? @jaimergp

Status

[x] Ready to go

codecov-commenter commented 3 years ago

Codecov Report

Merging #42 (a4e4bb4) into master (4f5c58a) will increase coverage by 0.03%. The diff coverage is 100.00%.

jaimergp commented 3 years ago

The unit test runs without failing even with this edit?

Yes, since it is a single-item array, the pytest.approx comparison works the same. I just checked:

t-kimber commented 3 years ago

Perfect! It's ready to be merged for me :)