openkinome / kinoml

Structure-informed machine learning for kinase modeling

https://openkinome.org/kinoml/

MIT License

51 stars 21 forks source link

Test failures #50

Closed schallerdavid closed 3 years ago

schallerdavid commented 3 years ago

Description

This PR aims to fix failures in the unit tests.

Todos

[x] fix NullFeaturizer
[x] fix test_datasetprovider_exporter_single_tensor_different_shapes
[x] fix test_datasetprovider_exporter_multiple_subtensors
[x] fix fix test_datasetprovider_exporter_multiple_subtensors
[ ] implement test_access_by_index_roundtrip

Questions

[ ] The only failure left is about test_access_by_index_roundtrip, which is simply not implemented. However, I am not quite sure how to implement this test. @t-kimber do you know what this is about?

Status

[ ] Ready to go

codecov-commenter commented 3 years ago

Codecov Report

Merging #50 (6900b39) into master (4b24e11) will increase coverage by 0.02%. The diff coverage is 100.00%.

schallerdavid commented 3 years ago

We did not implement test_access_by_index_roundtrip yet, will do it later. Merging now.