openkinome / kinoml

Structure-informed machine learning for kinase modeling
https://openkinome.org/kinoml/
MIT License
52 stars 21 forks source link

Fix multiprocessing of structural featurizers #92

Closed schallerdavid closed 3 years ago

schallerdavid commented 3 years ago

Description

@corey-taylor discovered a bug leading to never finishing processes when using multi-processing in the structural featurizers without specifying an output directory. In this case, the generated openeye molecule object will be written to disk as a PDB file, read back in as MDAnalysis universe, the file will be deleted and finally, the universe returned. This is the intended behavior when not specifying an output directory since the user was not interested in the file. However, standard MDAnalysis readers do not load into memory. Hence, during serialization in the multiprocessing scheme, the MDAnalysis reader will miss the file, since it has been deleted.

This PR makes sure we read the generated structure into memory. Thus, we can delete the file and still serialize the universe.

Questions

Status

codecov-commenter commented 3 years ago

Codecov Report

Merging #92 (dfdb17c) into master (5e38b6b) will not change coverage. The diff coverage is 25.00%.

corey-taylor commented 3 years ago

Have run test cases of docking with and without multiprocessing option - all worked smoothly.