Closed gvidon closed 9 years ago
@gvidon I'm happy with this. I'm not going to merge though, as @rgrp is maintainer, so we need to hear from him. So, please use your fork in DataPackagist for the moment.
@rgrp @gvidon
Two points:
validateUrl
method? I think not.So, I'm suggesting we merge and publish, but probably get rid of validateUrl
first.
@pwalsh happy with whatever is your call here. As noted in our discussion I have used Promises quite a bit (e.g. Recline) but IME I always find them more conceptually confusing than simple callback code. I get they avoid callback soup but I'm dubious of that value vs simplicity (and you can always promisify a callback setup - though it is somewhat painful). All that said this is very much your call.
The main issue is we need consistency across the libraries.
Ok so let's stick with promises, but let's use bluebird, which has nodeify and promisifyAll functions for full interop with callback code.
@gvidon:
@rgrp can you add me as a collaborator on npmjs.com so I can publish when ready (not urgent)
promise-polyfill
with bluebird
.validatrUrl()
schema
is an object — validate json against itschema
is a registry profile id — get schema object from registry and validate json against itschema
is empty than use default valuebase
for it, get schema object from registry and validate json against it.