Refactor models - Githubissues

openknowledge-archive / dpr-api

DEPRECATED - Data Package Registry API and Frontend

http://frictionlessdata.io/

MIT License

7 stars 6 forks source link

Refactor models #405

Closed zelima closed 7 years ago

zelima commented 7 years ago

WIP This PR code-base is refactored to keep logic part in one place and keep models as simple as possible.

All static methods moved from models to logic layer
tests updated appropriately
imports updated
functions renamed reasonably

this PR includes deletion and fix of 2 accidentally committed files that are were not related that exact PR. Changes were made in this commit https://github.com/frictionlessdata/dpr-api/pull/405/commits/66958e9470bed130dd52b129f6b90cc4036f3e2a

Bitstore refactor is in progress

refs #401

rufuspollock commented 7 years ago

@zelima this is an exemplary piece of coding in terms of the commit stages, the commit messages and the clarity of what you are doing. It is really easy to understand and review. Thank-you.

Approving now.