search

openkraken / kraken

A web standards-compliant, high-performance rendering engine based on Flutter.
https://openkraken.com
Apache License 2.0
4.93k stars 305 forks source link

[fix] kraken not support relative protocol #1444

Closed yifei8 closed 2 years ago

yifei8 commented 2 years ago

[fix] kraken not support relative protocol 由于HistoryModule的_replaceState过程中重新构建了bundle,此bundle未resolve,导致resolvedUri为空。

answershuto commented 2 years ago

@wssgcg1213 see see， 我记得之前有个讨论返回设计需要 URI ？

yifei8 commented 2 years ago

需补充用例

用例不变，前端业务代码无差异。

andycall commented 2 years ago

info • Private field could be final • lib/src/dom/elements/head.dart:35:21 • prefer_final_fields

测试没过

yifei8 commented 2 years ago

看起来和这个pr无关，具体error log在哪里看的

andycall commented 2 years ago

可以点下面的测试列表，其中 Integration Test / plugin_test (pull_request）里面跑的 lint 挂了