openkruise / charts

OpenKruise Helm Charts.
Apache License 2.0
9 stars 29 forks source link

[Issue22] Fix_hardcoded_references_to_namespace #23

Closed yike21 closed 1 year ago

yike21 commented 1 year ago

Ⅰ. Describe what this PR does

  1. fix hardcoded references to namespace kruise-system which are not templated with the variable {{ .Values.installation.namespace }}. It's related to issue/1121 and issue/22
  2. fix hardcoded references to namespace kruise-rollout which are not templated with the variable {{ .Values.installation.namespace }}.

    Ⅱ. Does this pull request fix one issue?

    fixes #22

    Ⅲ. Special notes for reviews

    @FillZpp @zmberg

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

Changes are automatically published when merged to master. They are not published on branches.

kruise-bot commented 1 year ago

Welcome @yike21! It looks like this is your first PR to openkruise/charts 🎉

zmberg commented 1 year ago

/lgtm

zmberg commented 1 year ago

/approve

yike21 commented 1 year ago

/assign @FillZpp

zmberg commented 1 year ago

/assign @furykerry

kruise-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry, zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openkruise/charts/blob/master/OWNERS)~~ [furykerry] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment