Allow to set extra environment variables on manager DaemonSet

mgeri commented 1 year ago

Describe what this PR does

This PR adds the possibility of set extra environment variables in the manager DaemonSet. This allows for example to support corporate proxy when downloading images with ImagePullJob setting the HTTP_PROXY, HTTPS_PROXY, NO_PROXY env vars.

Does this pull request fix one issue?

Fixes https://github.com/openkruise/kruise/issues/1120

Special notes for reviews

This is my first PR on this project. I tried to follow the contributing guidelines checklist, bumping also a new beta version for changes. Let me know if it's preferable to move the PR to an existing version.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

[ ] I have bumped the chart version according to versioning
[x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
[x] Any new values are backwards compatible and/or have sensible default.
[x] I have signed off all my commits as required by DCO.

Changes are automatically published when merged to master. They are not published on branches.

kruise-bot commented 1 year ago

Welcome @mgeri! It looks like this is your first PR to openkruise/charts 🎉

zmberg commented 1 year ago

@mgeri tks, can you immediate modify in kruise 1.3.0 version ?

mgeri commented 1 year ago

@zmberg sure, pushed the commit with changes in kruise 1.3.0 version

zmberg commented 1 year ago

@mgeri Sorry, I didn't express it clearly before. I think the EnvFrom field can be ignored for now. Is env enough at the current stage? So, I think envFromSecrets and envFromConfigMaps can be removed first.

mgeri commented 1 year ago

@zmberg Sorry, I did not understand. I agree. Pushed new changes. Thanks for the suggestions :-).

zmberg commented 1 year ago

/lgtm

FillZpp commented 1 year ago

/approve

kruise-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openkruise/charts/blob/master/OWNERS)~~ [FillZpp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openkruise / charts