search

openkruise / charts

OpenKruise Helm Charts.
Apache License 2.0
9 stars 24 forks source link

Fix Helm templating of the mutating/validating webhooks and namespaces #91

Open vpedosyuk opened 5 months ago

vpedosyuk commented 5 months ago

Fixes:

  1. https://github.com/openkruise/charts/issues/90
  2. https://github.com/openkruise/charts/issues/74
  3. maybe more

This PR basically fixes currently existing templating, doesn't change any defaults in values.yaml (but does apply some of them correctly now). See the changelog: https://github.com/vpedosyuk/openkruise-charts/blob/1b4abe91a1662df8a5d84540986eca1e2afbfd4c/versions/kruise/1.6.0/Chart.yaml#L22-L45

To get a better view on the changes I run:

diff --recursive versions/kruise/1.5.2/ versions/kruise/1.6.0/

I've successfully tested it with minikube and the default values.yaml:

helm install kruise versions/kruise/1.6.0

as well as with overriden values:

installation:
  namespace: custom-ns
  createNamespace: true

featureGates: >-
  PodWebhook=false,
  KruiseDaemon=false

Additional changes:

  1. When I tried running ct lint (from scripts/lint.sh) it failed due to the outdated configs so fixed some deprecated repo reference.
  2. When I tried running ct lint (from scripts/lint.sh) it failed due to the empty maintainers field so disabled this check as this particular field is actually empty for all versions of the chart.

Checklist:

Changes are automatically published when merged to master. They are not published on branches.

kruise-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openkruise/charts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kruise-bot commented 5 months ago

Welcome @vpedosyuk! It looks like this is your first PR to openkruise/charts 🎉

kruise-bot commented 4 months ago

@vpedosyuk: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.