search

openkruise / kruise-tools

Tools to use with the Kruise libraries
Apache License 2.0
43 stars 24 forks source link

Fix ads patch for rollout undo #71

Closed FillZpp closed 1 year ago

FillZpp commented 1 year ago

Signed-off-by: Siyu Wang FillZpp.pub@gmail.com

Fix ads patch for rollout undo

fixes https://github.com/openkruise/kruise/issues/1100

FillZpp commented 1 year ago

/approve

FillZpp commented 1 year ago

/cc @hantmac And when do we plan to release the next v1.0.5?

kruise-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, hantmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openkruise/kruise-tools/blob/master/OWNERS)~~ [FillZpp,hantmac] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hantmac commented 1 year ago

/cc @hantmac And when do we plan to release the next v1.0.5?

How about Friday? I have to collect the PRs in this release.

FillZpp commented 1 year ago

/cc @hantmac And when do we plan to release the next v1.0.5?

How about Friday? I have to collect the PRs in this release.

That's great, thank you. And please give this a /lgtm :)

hantmac commented 1 year ago

/lgtm