feat: Support set image operation for sidecarsets

openkruise / kruise-tools

Tools to use with the Kruise libraries

Apache License 2.0

47 stars 25 forks source link

feat: Support set image operation for sidecarsets #72

Closed chengleqi closed 1 year ago

chengleqi commented 1 year ago

Result

User can use kubectl kruise set image sidecarsets/test-sidecarset sidecar1=debian:11

Fix Issue

Fix: https://github.com/openkruise/kruise/issues/1106

Change

pkg/internal/polymorphichelpers/updatepodspec.go: Add a kruiseappsv1alpha1.SidecarSet branch.
pkg/cmd/set/set_image.go: Check if it is kruiseappsv1alpha1.SidecarSet type then use setSideCarImage function which is similar with setImage.
pkg/cmd/set/set_image_test.go: Add unit test

kruise-bot commented 1 year ago

Welcome @chengleqi! It looks like this is your first PR to openkruise/kruise-tools 🎉

kruise-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hantmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openkruise/kruise-tools/blob/master/OWNERS)~~ [hantmac] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

chengleqi commented 1 year ago

/hold sorry @hantmac I found a typo.