openkruise / kruise

Automated management of large-scale applications on Kubernetes (incubating project under CNCF)
https://openkruise.io
Other
4.68k stars 770 forks source link

Fix codeql and dependency problem #1748

Closed furykerry closed 2 months ago

furykerry commented 2 months ago

Ⅰ. Describe what this PR does

  1. solve non-pinned dependency problem (part of https://github.com/openkruise/kruise/issues/1706)
  2. fix incorrect codeql configuration

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.21%. Comparing base (0d0031a) to head (ca9ded0). Report is 86 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1748 +/- ## ========================================== + Coverage 47.91% 49.21% +1.29% ========================================== Files 162 191 +29 Lines 23491 19570 -3921 ========================================== - Hits 11256 9631 -1625 + Misses 11014 8689 -2325 - Partials 1221 1250 +29 ``` | [Flag](https://app.codecov.io/gh/openkruise/kruise/pull/1748/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openkruise/kruise/pull/1748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise) | `49.21% <ø> (+1.29%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zmberg commented 2 months ago

/lgtm /approve