openkruise / kruise

Automated management of large-scale applications on Kubernetes (incubating project under CNCF)
https://openkruise.io
Other
4.68k stars 770 forks source link

support pub pub.kruise.io/disable-fetch-replicas-from-workload=true #1758

Closed zmberg closed 2 months ago

zmberg commented 2 months ago

Ⅰ. Describe what this PR does

The custom workload implements the scale subresource, but the replicas value in the scale subresource is inaccurate, so they want to use the pub.kruise.io/protect-total-replicas.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.31%. Comparing base (0d0031a) to head (04fdf23). Report is 93 commits behind head on master.

Files with missing lines Patch % Lines
pkg/control/pubcontrol/pub_control.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1758 +/- ## ========================================== + Coverage 47.91% 49.31% +1.40% ========================================== Files 162 191 +29 Lines 23491 19616 -3875 ========================================== - Hits 11256 9674 -1582 + Misses 11014 8685 -2329 - Partials 1221 1257 +36 ``` | [Flag](https://app.codecov.io/gh/openkruise/kruise/pull/1758/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openkruise/kruise/pull/1758/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise) | `49.31% <25.00%> (+1.40%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ABNER-1 commented 2 months ago

/lgtm

furykerry commented 2 months ago

/lgtm /approve