Open chengjoey opened 1 month ago
/assign @hantmac
Attention: Patch coverage is 0%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 49.30%. Comparing base (
0d0031a
) to head (b1cd825
). Report is 94 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
...g/controller/statefulset/statefulset_controller.go | 0.00% | 5 Missing :warning: |
pkg/controller/daemonset/daemonset_controller.go | 0.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
since controller-runtime is not design to be interface compatible with client-go, can we change the lister to controler-runtime client.List, then it is no need to specify the index explicitly. daemonset and statefulset use the lister for historical reason, possibly for easier integration with upstream controller code.
Ⅰ. Describe what this PR does
if set namespace, mgr will use
multiNamespaceCache
, it useinformer
notshardIndexInformer
Ⅱ. Does this pull request fix one issue?
fix #1764
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews