openkruise / kruise

Automated management of large-scale applications on Kubernetes (incubating project under CNCF)
https://openkruise.io
Other
4.68k stars 770 forks source link

Fix/workloadspread time ut 241008 #1783

Closed AiRanthem closed 1 month ago

AiRanthem commented 1 month ago

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

add a sleep (e.g. time.Sleep(10*time.Seconds)) in Reconcile of WorkloadSpread

the UT TestDelayReconcile should pass

Ⅳ. Special notes for reviews

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.29%. Comparing base (0d0031a) to head (ba7da55). Report is 101 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1783 +/- ## ========================================== + Coverage 47.91% 49.29% +1.38% ========================================== Files 162 191 +29 Lines 23491 19616 -3875 ========================================== - Hits 11256 9670 -1586 + Misses 11014 8687 -2327 - Partials 1221 1259 +38 ``` | [Flag](https://app.codecov.io/gh/openkruise/kruise/pull/1783/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openkruise/kruise/pull/1783/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise) | `49.29% <ø> (+1.38%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.