openkruise / kruise

Automated management of large-scale applications on Kubernetes (incubating project under CNCF)
https://openkruise.io
Other
4.68k stars 769 forks source link

fix imagepulljob imagePullPolicy=Always does not take effect #1830

Closed zmberg closed 1 week ago

zmberg commented 1 week ago

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

https://github.com/openkruise/kruise/issues/1814

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.96%. Comparing base (0d0031a) to head (db33b1f). Report is 121 commits behind head on master.

Files with missing lines Patch % Lines
...controller/imagepulljob/imagepulljob_controller.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1830 +/- ## ========================================== + Coverage 47.91% 49.96% +2.05% ========================================== Files 162 192 +30 Lines 23491 24642 +1151 ========================================== + Hits 11256 12313 +1057 - Misses 11014 11054 +40 - Partials 1221 1275 +54 ``` | [Flag](https://app.codecov.io/gh/openkruise/kruise/pull/1830/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openkruise/kruise/pull/1830/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise) | `49.96% <0.00%> (+2.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openkruise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: