openlab-at-city-tech / webworkqa

WeBWorK integration for WordPress and BuddyPress
GNU General Public License v2.0
4 stars 2 forks source link

Like icon/count change for response only visible to user who liked it #103

Closed bree-z closed 7 years ago

bree-z commented 7 years ago

Question likes are working perfectly, but I'm noticing a problem with Like icons/count for responses.

Test Faculty view just after liking response

testfacultyview_tflike

Test Student view after Test Faculty liked response

teststudentview_tflike

Question URL: http://openlabdev.org/webwork-playground/#:problemId=local/ComplexFractions-Method2/single-binomial-easy.pg:questionId=11492

cc @moui72

boonebgorges commented 7 years ago

Hm, it looks like this has always been a bug - not new to the fall.

The root of the issue is that "like" counts returned from the server did not include responses, only questions. The reason why users were able to see their own likes is because the visible like counts are calculated: { other people's likes } + { my likes }; the latter data was available, while the former was not.

This is ready for testing.

bree-z commented 7 years ago

Thanks, Boone! This looks good to me!