openlab-at-city-tech / webworkqa

WeBWorK integration for WordPress and BuddyPress
GNU General Public License v2.0
4 stars 2 forks source link

Improved sort for Section filter dropdown #113

Closed boonebgorges closed 6 years ago

boonebgorges commented 6 years ago

Should be sorted by:

  1. Chronological DESC. Use FXX/SXX to determine dates.
  2. Alphabetical ASC within a given term.

See https://openlab.citytech.cuny.edu/groups/openlab-webwork-integration-project/forum/topic/possible-bug-2/ for more background.

boonebgorges commented 6 years ago

This has been implemented. Not sure how to test it on openlabdev.org/webwork-playground, where we only have one source section. @drdrew42 Are there a couple different sections in WW-Dev that we'll be able to use for testing? Maybe not worth a huge lift, as this is a pretty straightforward change, and may not need extremely thorough testing.

drdrew42 commented 6 years ago

I have "testing" courses set up for Tyler and Bree, I may have to remind them of their logins and the URL for these hidden courses... but that's a way we can get multiple sections involved.

boonebgorges commented 6 years ago

Thanks, @drdrew42.

I've also attached a screenshot from my local if it helps.

screenshot_2018-05-02_09-58-36

bree-z commented 6 years ago

Hi @drdrew42 -

I'm able to log in to WW-Dev, but I'm not sure how to find different courses. If I click on Courses in the left sidebar nav it takes me to the list of actual live courses (http://mathww.citytech.cuny.edu/webwork2/). Or is it easier to test on production after the release?

Thanks!

drdrew42 commented 6 years ago

You have a separate course from long ago - it's unlisted on the public-facing "courses" page...

http://mathww.citytech.cuny.edu/webwork2/MAT9999-S17-Zuck

IIRC, your login and password are both 'bzuck'

bree-z commented 6 years ago

Thanks, @drdrew42 !

@boonebgorges , when I ask a question from MAT9999-S17-Zuck, the question appears on the OLdev WW site with the correct course/section information, but it doesn't appear in the dropdowns.

filters

There are a few questions on the site now from the MAT9999-S17-Zuck, e.g.:

http://openlabdev.org/webwork-playground/#:problemId=local/HigherRoots/square-roots-with-negatives.pg:questionId=11910

and

http://openlabdev.org/webwork-playground/#:problemId=local/IntegerExponents/multiply-divide-easy.pg:questionId=11905

Thanks!

boonebgorges commented 6 years ago

Good catch, Bree. This appears to be an unrelated issue, having to do with the changes I mentioned here: https://openlab.citytech.cuny.edu/groups/openlab-webwork-integration-project/forum/topic/file-uploads-and-openlabdev-org-webwork-playground-partial-reset/ It turns out that the change I made to openlabdev.org accidentally got rolled back a couple years ago (my own carelessness), so that your questions from the Zuck class were stored in the wrong place. As such, they weren't being detected by the code that is responsible for building the 'Select' dropdowns.

I've remade the change. Could you please create another question from the Zuck class? It should now go to the correct place, which should then populate the dropdown.

bree-z commented 6 years ago

This is populating correctly now, thanks! I can't test the chronological descending section order, but all other filter functionality is working. I've made a note to be sure to check this out in post-release testing.