search

openlab-at-city-tech / webworkqa

WeBWorK integration for WordPress and BuddyPress
GNU General Public License v2.0
4 stars 2 forks source link

Localization #115

Closed boonebgorges closed 3 years ago

boonebgorges commented 6 years ago

Strings are not currently localizable.

boonebgorges commented 5 years ago

See https://github.com/livinglab/webwork-for-wordpress/issues/155 - this will need some other technique, or at least a JS-based progressive enhancement, to be l18n-friendly.

boonebgorges commented 5 years ago

I wanted to take care of this work now because it's somewhat fragile - it involves touching pretty much every visible string in the application. I believe I've caught everything, but I'll leave the ticket open to address clean-up issues.

@bree-z During your next round of testing, just keep an eye out for places where either (a) text is obviously missing, or (b) text is rendered with some weird code wrapped around it (like { __( 'Hello', 'webwork' ) } where you'd expect to see Hello).

bree-z commented 3 years ago

Hi Boone, I haven't seen anything exactly you've described above, but I found a few places where LaTeX doesn't render correctly. Sorry if these issues aren't related to this ticket:

  1. Explore - Instantaneous Rate of Change: Problem 1

WW URL: http://146.111.135.122/webwork2/WW-Dev/Explore_-_Instantaneous_Rate_of_Change/1/?effectiveUser=studentA Q&A site URL: http://hardg.com/webwork/#:problemId=Contrib/CUNY/CityTech/Calculus/setExplore_-_Instantaneous_Rate_of_Change/geogebra-slopes-zoom.pg:questionId=23

WeBWorK:

Screen Shot 2021-08-26 at 5 34 30 PM

Q&A site:

Screen Shot 2021-08-26 at 5 34 16 PM Screen Shot 2021-08-26 at 5 34 23 PM
  1. Derivatives - Limit Definition: LaTeX doesn’t render correctly for parts of the question highlighted in yellow that users click to expland/collapse.

WW URL: http://146.111.135.122/webwork2/WW-Dev/Derivatives_-_Limit_Definition/3/?effectiveUser=studentA Q&A site URLs: http://hardg.com/webwork/#:problemId=CUNY/CityTech/Calculus/setDerivatives_-_Limit_Definition/diff-quotient-poly.pg:questionId=27 , http://hardg.com/webwork/#:problemId=CUNY/CityTech/Calculus/setDerivatives_-_Limit_Definition/delta-rational.pg:questionId=25

WeBWorK:

YellowHeadingsWW

Q&A site:

YellowHeadings

Thanks!

boonebgorges commented 3 years ago

Thanks, @bree-z

Neither of these items are related to localization changes.

I can't reproduce item 1. Perhaps there was some momentary hiccup in your LaTeX renderer? If not, let's open a new ticket, with details on your browser/OS config.

I'll open a separate ticket for item 2, which is a bit of a head-scratcher and is probably not something we can fix in the short term.