search

openlab-at-city-tech / webworkqa

WeBWorK integration for WordPress and BuddyPress
GNU General Public License v2.0
4 stars 2 forks source link

Discourage/prevent image insertion without alt text #118

Closed boonebgorges closed 6 years ago

boonebgorges commented 6 years ago

Previously: #107

boonebgorges commented 6 years ago

This turns out to be a moderately difficult technical task. I've attached a gif of a first pass at an error workflow. If we think that some version of this is worth doing, the next step is likely for @jennaspevack to make some suggestions about better styling/wording.

peek 2018-05-01 14-05

boonebgorges commented 6 years ago

(I've pulled the changes to the webwork-playground environment so that you can test in a live environment if that's easier.)

bree-z commented 6 years ago

Functionality is working well. Does this still need design input from @jennaspevack ? Thanks!

boonebgorges commented 6 years ago

It would be nice to get thoughts from @jennaspevack, even if it's just "that looks good" - the main reason being that we may want to adapt this change for the OpenLab more generally at some point. (The main design points are: 1. the wording, styling, placement of the 'You must supply...' message, and 2. the red outline on the 'Alt Text' input field.)

"Looks good for OL-WW, may need more revision for OL" is a perfectly good answer for now!

jennaspevack commented 6 years ago

Looks great! Sorry for the delay.

boonebgorges commented 6 years ago

Great, thanks! There may still be some weirdness on mobile, but we are addressing in #122, so I think this can be closed.