Closed boonebgorges closed 5 years ago
I've just pushed a first version of this to openlabdev.org. Here's a brief gif:
A few assumptions and questions:
Another item to add to my list:
Yes.
How about "Question from a student" text is kept, and the word "student" gets a tooltip with the student's name or the real name just replaces the student text on-focus/on-click?
Maybe use text-decoration: underline #0043af dotted or similar to indicate tooltip/hover?
Not sure if this is what you had in mind...
Maybe use text-decoration: underline #0043af dotted or similar to indicate tooltip/hover?
Sounds good. I'll work on this next week.
I think if a student posts a question as anonymous all replies should be the same.
All replies? Or all student replies? Or all replies by the original question author? The latter seems "correct" to me - and maybe the reply title can be something like "Question Author" or something like that, in place of where the user name would be? See screenshot for a reminder of how the reply author names appear.
Yes, all replies from the anonymous student who originally posted the question.
Just to clarify I'm assuming that if another student replies to a question they don't have the option of posting anonymously. My understanding was that it was just for questions.
"Question Author" sounds good.
All sounds good. Thanks for confirming!
Here's a first pass at the hover tooltip. Visible only to instructors/admins:
It's better to make the entire string hover-able, for translation reasons. Note that I'm using the same tooltip styling/behavior as the "Join / login to like" tooltip. @jennaspevack If you're happy with the way this looks, I'll apply it to anonymous replies as well.
The 'Question Author' functionality has now been implemented. (That is: in a thread of replies to an anonymous question, replies written by the original question author have the title 'Question Author' rather than the user's name.) I went ahead and implemented the "real name" tooltip for this as well, though it can easily be changed if we decide we'd like a different UI.
Thanks, Boone! This is working as expected and the tooltip looks good to me!
@jennaspevack not sure if you want to take a look at the tooltip, but otherwise we can close this, thanks!
Thanks Boone!
The tooltip background color doesn't pass WAVE. Could we change that tooltip box .__react_component_tooltip.type-info to background-color: #c4c4c4 and text color: #000?
And also the little triangle, .__react_component_tooltip.type-info.place-top:after border-top-color: #c4c4c4?
Example: https://www.dropbox.com/s/9qboats98ra0dlt/anonomous-hover.png?dl=0
I noted an issue with the anonymous link style here: https://github.com/livinglab/webwork-for-wordpress/issues/149
Sure thing. I've made the change.
Thanks, Boone and Jenna!
This looks good to me. When I inspect the element I see:
.__react_component_tooltip.type-info { background-color: #c4c4c4; color: #000; }
I'm not sure where to find react_component_tooltip.type-info.place-top:after border-top-color but the little triangle appears to be the same background color, and I don't see any WAVE contrast errors.
Boone or Jenna, I'll let you decide if that's good enough to close. Thanks! :)
Perfect. Thanks!