"Question from..." styling

openlab-at-city-tech / webworkqa

WeBWorK integration for WordPress and BuddyPress

GNU General Public License v2.0

4 stars 2 forks source link

"Question from..." styling #161

Closed boonebgorges closed 5 years ago

boonebgorges commented 5 years ago

See https://www.dropbox.com/s/k51njug4qvyt48s/OLWW_StyleGuide-miniupdate.png?dl=0 for hover etc.

bree-z commented 5 years ago

I think this looks good. @jennaspevack , do you want to take a look just to double check? :) Thanks!

jennaspevack commented 5 years ago

In the mockup I have the hover as black, no underline.

Currently, on dev I'm seeing the hover as blue, no underline. Maybe we made this change I've forgotten? If not, I think the black, no underline still works.

boonebgorges commented 5 years ago

It was blue or black, depending on visited state. I must have misread the mockup, which indicates that it should be black regardless of visited state. (Note this means that there's no visual difference between visited-hover and unvisited-hover, though this seems like not a big deal to me.) I've made the change.

bree-z commented 5 years ago

Sorry, I misread the mockups too! So, just to make sure I have this right, what I see is:

Unvisited: blue w/underline
Visited: black w/underline
Hover (both visited and unvisited): black, no underline

If this is correct, I think we can close this. Thanks!

boonebgorges commented 5 years ago

This is getting shipped today. We can tweak for the next release if need be. Thank you!