moui72
commented
8 years ago Thanks for picking up the slack on this, I meant to put a comment in but screwed it up somehow. Your description sounds right. Might be useful also or instead to have the filter breadcrumbs be interactive and include a clear filters button up there.
On Tue, Aug 16, 2016, 2:13 PM Boone Gorges notifications@github.com wrote:
I'm going to flesh this out with what I assume you mean in the ticket title:
a. Back button works properly when navigating between single-question and question index. Eg: from http://openlabdev.org/webwork-playground/, click a question header; the back button will return you to the main page. b. Back button does not work with index filters. Eg, visiting http://openlabdev.org/webwork-playground/ and clicking "Unanswered Questions" will change the view so that you're viewing unanswered questions; Back does not take you to the unfiltered view.
If this doesn't accurately capture your report, please provide more details.
The primary issue here is that I'm not modifying the URL when filtering the index page. The entire application runs in JS, and uses hash navigation, which doesn't change when selecting a filter. I'll have to solve this by either (a) interacting with the URL when applying sidebar filters, or (b) manually modifying the browser history.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/livinglab/webwork-for-wordpress/issues/24#issuecomment-240189119, or mute the thread https://github.com/notifications/unsubscribe-auth/ADtKPETfXa-sL9xntFf7vpIM03hAhlOqks5qgf2_gaJpZM4JlpsK .
boonebgorges
drdrew42
I'm going to flesh this out with what I assume you mean in the ticket title:
a. Back button works properly when navigating between single-question and question index. Eg: from http://openlabdev.org/webwork-playground/, click a question header; the back button will return you to the main page. b. Back button does not work with index filters. Eg, visiting http://openlabdev.org/webwork-playground/ and clicking "Unanswered Questions" will change the view so that you're viewing unanswered questions; Back does not take you to the unfiltered view.
If this doesn't accurately capture your report, please provide more details.
The primary issue here is that I'm not modifying the URL when filtering the index page. The entire application runs in JS, and uses hash navigation, which doesn't change when selecting a filter. I'll have to solve this by either (a) interacting with the URL when applying sidebar filters, or (b) manually modifying the browser history.