search

openlab-at-city-tech / webworkqa

WeBWorK integration for WordPress and BuddyPress
GNU General Public License v2.0
4 stars 2 forks source link

ability to "clear" filters #47

Closed moui72 closed 8 years ago

moui72 commented 8 years ago

There is no way to reset a filter to "off" state -- you can only change its value.

For example: if I filter to a particular problem set and then I want to go back and look at all unanswered questions, I have to navigate to "home" to clear the problem set filter.

It might be nice to have a "show all" for the higher level filters (problem set, section, course) like there is for answered/unanswered.

clear-filter

boonebgorges commented 8 years ago

Good call. I've added Show All to each filter. It's slightly awkward, because selecting Show All will result in the "Select Course" etc filter value being shown (instead of "Show All"). Play with it and see if it makes sense to you. If it feels weird, we can ask Jenna for help.

moui72 commented 8 years ago

I think it's good now, no complaints. Maybe @bree-z could also take a quick look and see what she thinks?

bree-z commented 8 years ago

I agree that it's slightly awkward - I think it would be better to have some visual reminder that users have filtered for "All". But this is better than no "Show All" option, so maybe this is something to improve in the next iteration?

boonebgorges commented 8 years ago

Yeah. The problem with that is that "Show All" is actually the same thing as "Select Course" or whatever, so it feels weird and redundant to have Show All be a persistent value.

I think what we currently have is good enough for now. I doubt anyone will find this awkward in actual use, but if they do, we can bring it to Jenna's attention for further study.