openlab-at-city-tech / webworkqa

WeBWorK integration for WordPress and BuddyPress
GNU General Public License v2.0
4 stars 2 forks source link

sidebar on help pages not accessible #62

Closed moui72 closed 7 years ago

moui72 commented 8 years ago

the sidebar on help pages is not visible on mobile resolutions.

is there anyway we can rig it to expand with a click on the magnifying glass the way that the filters do on the question index page?

i am talking about the sidebar on pages such as the following http://openlabdev.org/webwork-playground/help/#

boonebgorges commented 8 years ago

Sure thing. My apologies for missing this before.

When you say "click on the magnifying glass" I assume you mean "click on the hamburger icon at the left", which is generally the convention for nav menus on mobile. This is what I've implemented on http://openlabdev.org/webwork-playground/

boonebgorges commented 7 years ago

I misunderstood @moui72's comment above - it's just as he said, the sidebar content (which consists of a map of help pages) should appear in the magnifying glass modal, where the question filters appear when viewing WW content. I've made that change in https://github.com/livinglab/openlab/commit/4ae35d9c3f5e455e1acf3e298b313d1d07d2f28e

moui72 commented 7 years ago

this looks good. a minor issue is that the top of the menu is ~3px too far down, showing some of the page behind it. i think it should be flush with the hamburger white margin below the black bar that contains the magnifying glass. if you don't feel like messing with that right now it's fine to leave it until a future update.

screenshot_20170119-130050

boonebgorges commented 7 years ago

Thanks @moui72 - I spent two minutes looking and I couldn't see at a glance where that 3px is coming from in order to make a proper fix. So I did a clunky negative-margin trick instead. Could you confirm that it's addressing the issue?

moui72 commented 7 years ago

I am not seeing any change :(

boonebgorges commented 7 years ago

Did you do a hard refresh? The stylesheets can be quite sticky.

On 01/24/2017 01:53 PM, Tyler J. Peckenpaugh wrote:

I am not seeing any change :(

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/livinglab/webwork-for-wordpress/issues/62#issuecomment-274919053, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPDY-sjHzHDmMUD6GJlVCIwzfFdJJFvks5rVla8gaJpZM4KX48C.

bree-z commented 7 years ago

FWIW, I see the same thing as @moui72, on iOS10.2/Safari.

boonebgorges commented 7 years ago

Thanks, @bree-z. Since this is quite minor and presumably doesn't affect our current release, and is proving to be non-trivial to solve, I'm going to open a separate ticket for it.

moui72 commented 7 years ago

thanks all. and yes, i tried everything i could think of to make sure the cache was clear... :man_shrugging: stupid browsers and their stupid caches

boonebgorges commented 7 years ago

Thanks to both of you :)