search

openlab-at-city-tech / webworkqa

WeBWorK integration for WordPress and BuddyPress
GNU General Public License v2.0
4 stars 2 forks source link

User should get email notification when someone responds to her question #68

Closed boonebgorges closed 7 years ago

boonebgorges commented 7 years ago

First pass at this functionality is up. The message sent is as follows (Sally Smith is the person who replied)

Subject:

[City Tech OpenLab] Sally Smith has replied to your question

Message:

Sally Smith has replied to your question on City Tech OpenLab.

To read and reply, visit [question url].

Suggestions on message text are welcome.

Users do not receive notifications when they reply to their own questions.

drdrew42 commented 7 years ago

Just to clarify, this email is sent to the "owner" of the question?

Overall, the message is straight to the point and I don't think we need much more detail. The subject line is fine, but should the bracketed text mention OpenLab-WeBWorK? Something to distinguish it from other OpenLab emails (does this happen?)

boonebgorges commented 7 years ago

Just to clarify, this email is sent to the "owner" of the question?

Correct - the person who asked the question gets a notification when a response is posted to the question.

The subject line is fine, but should the bracketed text mention OpenLab-WeBWorK? Something to distinguish it from other OpenLab emails (does this happen?)

Good call. I will make this change.

boonebgorges commented 7 years ago

The subject line is fine, but should the bracketed text mention OpenLab-WeBWorK? Something to distinguish it from other OpenLab emails (does this happen?)

I've made the change.

moui72 commented 7 years ago

I posted a new question and responded to it, and got an E-mail notification.

I noticed that when I responded to a preexisting question I had posted, there was no notification. Is this intended/does it matter?

Also if I respond to my own question, there is no notification (looking at the commit, this is clearly intended, but I wanted to document it here for future reference)

moui72 commented 7 years ago

everything looks good otherwise

boonebgorges commented 7 years ago

I noticed that when I responded to a preexisting question I had posted, there was no notification. Is this intended/does it matter?

Is this because the preexisting question was written by the same account as the one you were using to leave a response? Off the top of my head, I can't think of a reason why preexisting questions wouldn't work the same way as new ones.

moui72 commented 7 years ago

I think it ended up just being very delayed for some reason. Probably nothing to worry about, seems to be working now.

boonebgorges commented 7 years ago

Excellent - thank you!

On 01/23/2017 09:23 PM, Tyler J. Peckenpaugh wrote:

I think it ended up just being very delayed for some reason. Probably nothing to worry about, seems to be working now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/livinglab/webwork-for-wordpress/issues/68#issuecomment-274690995, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPDY7D8Qq354M8y-uDkdDSqBTLd1HjIks5rVW7GgaJpZM4LCIta.