search

openlab-at-city-tech / webworkqa

WeBWorK integration for WordPress and BuddyPress
GNU General Public License v2.0
4 stars 2 forks source link

add in-progress question state #90

Closed moui72 closed 7 years ago

moui72 commented 7 years ago

Implement an in-progress state for a question (not answered, but responded to). Jenna to design and decide on separate filter or additional option in the current one.

boonebgorges commented 7 years ago

This is ready to test on openlabdev.org/webwork-playground.

I interpreted the sidebar filter options as being mutually exclusive: Even though "In-Progress" items are technically "Unanswered" (in the sense that they don't yet have an accepted answer), the "Unanswered" filter only returns those items that have no responses. Let me know if this feels right.

bree-z commented 7 years ago

I've tested, and this looks good to me, i.e. it matches Jenna's comps, and works fine. Answering a question but not marking as answered changes it to the "In-Progress" label, and the question appears correctly based on filter choices.

The "Unanswered" filter returning those items that have no responses seems right to me, but I'll let others weigh in.

moui72 commented 7 years ago

i think the current functionality seems right, and it seems to be working. holding off on closing as I think it might be ideal to have @jspevack check off on it.

jennaspevack commented 7 years ago

A very small thing :) The outline/stroke around the response box should be the same color blue as the "In-Progress" header. It's currently the "Answered" blue.

Otherwise, looks good!

boonebgorges commented 7 years ago

Thanks, @jennaspevack! This is ready for another test.

moui72 commented 7 years ago

@bree-z can I ask you to handle this?

jennaspevack commented 7 years ago

thanks @boonebgorges looks good!

bree-z commented 7 years ago

will do, @moui72! i'll take a look tomorrow.

bree-z commented 7 years ago

This looks good, thanks! I'm going to close this one.