openlawlibrary / pygls

A pythonic generic language server
https://pygls.readthedocs.io/en/latest/
Apache License 2.0
568 stars 103 forks source link

pyodide_testrunner: display console on error #254

Closed perrinjerome closed 2 years ago

perrinjerome commented 2 years ago

Description (e.g. "Related to ...", etc.)

If something is wrong with the test running on CI and selenium get a timeout, the test output was not displayed.

Code review checklist (for code reviewer to complete)

perrinjerome commented 2 years ago

Example test failure without any output because of a timeout (before this change): https://github.com/perrinjerome/pygls/runs/7270783998?check_suite_focus=true

Example test failure with the test output (after this change): https://github.com/perrinjerome/pygls/runs/7271213761?check_suite_focus=true#step:5:357

( this test failure was a run with some unfinished changes, the test does not fail like this on master branch )

perrinjerome commented 2 years ago

Thanks ! When I was running this, 120 seconds was enough to run the full test and a bit long when waiting for test to timeout in case of that error I had. I guess this is a good value for now.