openlawlibrary / pygls

A pythonic generic language server
https://pygls.readthedocs.io/en/latest/
Apache License 2.0
585 stars 104 forks source link

Make `name` and `version` arguments mandatory #295

Closed alcarney closed 1 year ago

alcarney commented 1 year ago

Description (e.g. "Related to ...", etc.)

I think in #274 we said we wanted to make the name and version arguments to a LanguageServer object mandatory? This PR removes the warning and default arguments meaning they now have to be provided by the language server author.

Code review checklist (for code reviewer to complete)

tombh commented 1 year ago

(Saw you fix the test as I was typing 😏)

Well remembered! The v1 release is the perfect moment to include this.