search

openlawlibrary / pygls

A pythonic generic language server
https://pygls.readthedocs.io/en/latest/
Apache License 2.0
585 stars 104 forks source link

some type-checking fixes #298

Closed dimbleby closed 1 year ago

dimbleby commented 1 year ago

A handful of type-checking fixes.

There's lots more that could be done - try mypy --strict pygls if you want to see. But this covers enough of the public API that typechecking from jedi-language-server is happy.

tombh commented 1 year ago

Thank you. Do you need these in a release? Would you like to add the conventional commit tag, bump the patch version and add a quick note to the CHANGELOG? I can get it released straight away then.

And yes, mypy --strict support is definitely something I'd like to see at some point.

dimbleby commented 1 year ago

No hurry at all, I'm just passing the time and making myself useful

tombh commented 1 year ago

Could you rebase latest master? Then I'll get this merged. I know we don't yet require commit message syntax. But could you add a chore: please. I'd like for us to start requiring Conventional Commit syntax in order to auto generate the CHANGELOG file.

tombh commented 1 year ago

Great, thank you ✨