openlawlibrary / pygls

A pythonic generic language server
https://pygls.readthedocs.io/en/latest/
Apache License 2.0
568 stars 103 forks source link

fix: Pin `lsprotocol` depdency #345

Closed tombh closed 1 year ago

tombh commented 1 year ago

This is on recommendation from the main lsprotocol developer. There is a much larger discussion around pinning in general, see: https://github.com/openlawlibrary/pygls/issues/331

Code review checklist (for code reviewer to complete)

tombh commented 1 year ago

We've actually got lsprotocol==2023.0.0a2 in master now, so I'll close this branch.

But one little open question I have is, is it worth testing out lsprotocol==2023.0.0a2 in the wild a little bit before making a new release of Pygls? #331 shows that there was a lot to take into consideration in introducing pinning, so maybe we should just make sure there aren't any unintended consequences first?

karthiknadig commented 1 year ago

I think it is safe to pin 2023.0.0a2. I will be releasing 2023.0.0a3 next week and it will need some time in the wild to settle. My plan is to get this to stable this quarter. Then we can have pre-releases without impact to main pygls

tombh commented 1 year ago

Thanks for the heads up. We'll make a release of that 2023.0.0a2 pin then, so you'll have the freedom to let 2023.0.0a3 into the wild without putting Pygls users into a tight spot.