Closed tombh closed 1 year ago
This has the downside of now assigning all these changes to me, the committer, which means we lose some nuance as to the history and context of the original changes.
I stumbled across something that might help with this a little while ago - .git-blame-ignore-revs it looks like you can configure git to ignore some commits when doing a git blame
Looks like GitHub supports it too
Nice! Added it 😀
scripts/generate_client.py
currently outputs non Black-compatible code
another way would be just not to format the generated code
[tool.black]
exclude = "pygls/lsp/whatever"
Nice idea! Updated and all green CI now, thanks.
Black is an opinionated code formatter https://black.readthedocs.io/en/stable/
This introduces a lot of formatting changes.
~This has the downside of now assigning all these changes to me, the committer, which means we lose some nuance as to the history and context of the original changes. But maybe it is better to "rip the bandage" to begin enjoying consistent formatting?~ This isn't actually such a problem because of
.git-blame-ignore-revs
TODO:
scripts/generate_client.py
currently outputs non Black-compatible code. We could either make it output compatible code, or just add a compulsory Black formatting step. I think we just add the extra Black format step.Code review checklist (for code reviewer to complete)