openlawlibrary / pygls

A pythonic generic language server
https://pygls.readthedocs.io/en/latest/
Apache License 2.0
568 stars 103 forks source link

ci: retry Pyodide tests #355

Closed tombh closed 1 year ago

tombh commented 1 year ago

This is to get around a curious issue that isn't resolved by dependency locking. The flakey error is:

ImportError: cannot import name 'Any' from 'typing_extensions'

Code review checklist (for code reviewer to complete)

alcarney commented 1 year ago

Sorry, I keep meaning to look into this.

Looking at things more closely, I think the pip install step based on a locked set of dependencies that was added in https://github.com/openlawlibrary/pygls/commit/476eaf13c5d6e532c48b3d1f349dfcdefcfc0ca6 should probably be moved to here

Aside from the selenium stuff, run.py only needs to package pygls plus it’s test suite into a wheel so that it can be pushed inside the pyodide runtime where the tests are actually run. It’s this "hidden" pip install step inside the runtime itself that is causing the issue and needs some help picking the right version of everything.

tombh commented 1 year ago

Ahh, yes that makes sense, it's the Pyodide runtime that needs the pinned deps. So there's still a chance 😀

But no rush, this PR should get us by.