openlawlibrary / pygls

A pythonic generic language server
https://pygls.readthedocs.io/en/latest/
Apache License 2.0
568 stars 103 forks source link

Initial support for notebook document sync methods #356

Closed alcarney closed 12 months ago

alcarney commented 1 year ago

Description (e.g. "Related to ...", etc.)

nbsync

This is a first pass at implementing support for the notebookDocument/did* group of messages from the LSP spec.

Closes #311

Code review checklist (for code reviewer to complete)

alcarney commented 1 year ago

This is probably good enough to merge now, I expect the best way to get some feedback is to get this out there in a release so people can try it out

Any thoughts?

tombh commented 1 year ago

Let's merge this then? Would be good to get the confirmation from Karthik, but sounds like you're happy Alex?

alcarney commented 1 year ago

but sounds like you're happy Alex?

Yes :)