Closed alcarney closed 1 year ago
@tombh would it be possible to relax commit body length lint? I'd like to include a url in the commit message but it's triggering the rule.... https://github.com/openlawlibrary/pygls/actions/runs/6018606341/job/16327093410?pr=359#step:7:27
Sure! Those are just the defaults anyway.
This looks good, actually I mean great, some really nice changes. Let's merge this then?
Yes, sounds good :)
Description (e.g. "Related to ...", etc.)
This renames the new client objects to something that better reflects their purpose.
pygls/client.py
,Client
is now calledJsonRPCClient
LanguageClient
inpygls/lsp/client.py
is now calledBaseLanguageClient
This PR also performs some other house keeping tasks
lsprotocol
to2023.0.0a3
which should include all the fixes required for #356types
module rather than importing them directly which cuts out the 100s of lines of imports at the top of the fileJsonRPCClient
andBaseLanguageClient
Code review checklist (for code reviewer to complete)