feat: add workspace symbol resolve

openlawlibrary / pygls

A pythonic generic language server

https://pygls.readthedocs.io/en/latest/

Apache License 2.0

568 stars 103 forks source link

feat: add workspace symbol resolve #362

Closed karthiknadig closed 1 year ago

karthiknadig commented 1 year ago

Description (e.g. "Related to ...", etc.)

Add support for workspace symbol resolve request.

Code review checklist (for code reviewer to complete)

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Commit messages are meaningful (see this for details)
[ ] Tests have been included and/or updated, as appropriate
[ ] Docstrings have been included and/or updated, as appropriate
[ ] Standalone docs have been updated accordingly

karthiknadig commented 1 year ago

@alcarney @tombh I did not see a test for workspace symbol, this change updates existing support for workspace symbol to enable resolve if "workspaceSymbol/resolve" is implemented.

tombh commented 1 year ago

Great, thank you. It looks like a pretty straightforward change. Just needs a rebase of main and we can get this merged?

karthiknadig commented 1 year ago

@tombh re-based to main.

tombh commented 1 year ago

Damn, needs rebasing again! Busy day for that pygls/capabilities.py file, which is great 💪

Also, does this contribute to the LSP 3.17 support as well? Outlined in https://github.com/openlawlibrary/pygls/issues/346

karthiknadig commented 1 year ago

@tombh Yes this covers the symbol resolve.

tombh commented 1 year ago

Great 🎉 Thank you.