openlawlibrary / pygls

A pythonic generic language server
https://pygls.readthedocs.io/en/latest/
Apache License 2.0
563 stars 102 forks source link

chore(ci): bust cache #373

Closed tombh closed 12 months ago

tombh commented 12 months ago

Having problems in CI, looks like a bug got cached, hopefully just busting the cache fixes it.

tombh commented 12 months ago

Actually, wait, I have another idea. Why not make -bustme be a Actions ENV var, so we can bust the cache just by changing the var in settings! I'll push that when I get a moment soon...

alcarney commented 12 months ago

Also, if you know which cache is bad you should be able to delete it from here - https://github.com/openlawlibrary/pygls/actions/caches

alcarney commented 12 months ago

I think the cache must be capturing the exact version of Python - (the Windows error message seems more useful)

No Python at '"C:\hostedtoolcache\windows\Python\3.11.4\x64\python.exe'

Which makes sense when you see that earlier in the run Python 3.11.5 was installed

Successfully set up CPython (3.11.5)

Is there a way for us to get the minor Python version number into the cache key? I wonder if actions/setup-python exports that as a step output :thinking:

tombh commented 12 months ago

I didn't know about that cache page! That's really good to know.

And fantastic you found the underlying cause, I added the minor version to the cache key like you suggested.