openlawlibrary / pygls

A pythonic generic language server
https://pygls.readthedocs.io/en/latest/
Apache License 2.0
563 stars 102 forks source link

Remove dependency on `typeguard` #411

Closed karthiknadig closed 9 months ago

karthiknadig commented 9 months ago

Description (e.g. "Related to ...", etc.)

Remove dependency on typeguard. fixes https://github.com/openlawlibrary/pygls/issues/409

Code review checklist (for code reviewer to complete)

tombh commented 9 months ago

Great, thanks. Just request a review from me or Alex when this is ready.

karthiknadig commented 9 months ago

@tombh I don't have permissions to add reviewers. This is ready now for review.

tombh commented 9 months ago

Oh, sorry, I didn't realise. It looks good, I've approved it. I'll just wait a bit in case Alex gets a chance to look too.

tombh commented 9 months ago

Would you like a Pygls release? Or wait a bit for some bleeding edge testers?

karthiknadig commented 9 months ago

I will do more tests with a few servers and let you know.

karthiknadig commented 9 months ago

I tested this on a few different servers. It seems to be working as expected. This can be published.

tombh commented 9 months ago

Great, thank you. Here's the PR for the release https://github.com/openlawlibrary/pygls/pull/412