ci: don't let Pyodide test fail the whole build

openlawlibrary / pygls

A pythonic generic language server

https://pygls.readthedocs.io/en/latest/

Apache License 2.0

563 stars 102 forks source link

ci: don't let Pyodide test fail the whole build #420

Closed tombh closed 9 months ago

tombh commented 9 months ago

It doesn't seem to. It still considers the whole build to have failed putting that red cross icon next to the commit message. There's a lot of discussion about a allow-failure it here: https://github.com/actions/runner/issues/2347

So I've just added || true for now. What do you think?

Also, there's another cheeky commit that just prevents both on-push and on-pull_request CI runs running at once.

alcarney commented 9 months ago

It still considers the whole build to have failed putting that red cross icon next to the commit message.

Strange... as the summary header in the Actions tab considered it a success :man_shrugging:

So I've just added || true for now. What do you think?

Seems fine to me

tombh commented 9 months ago

Yeah, I saw that too. Seems odd that they wouldn't then reflect that status in icons next to the commit messages.