openlawlibrary / pygls

A pythonic generic language server
https://pygls.readthedocs.io/en/latest/
Apache License 2.0
568 stars 103 forks source link

chore: remove deprecated code #492

Closed alcarney closed 3 weeks ago

alcarney commented 3 weeks ago

Description (e.g. "Related to ...", etc.)

This PR removes the code we've previously deprecated (the old workspace and position encoding methods). All removed methods have an alternative which has been documented in the draft migration guide.

I have also started migrating some of my projects and have added them to the list of known migrations.

Code review checklist (for code reviewer to complete)

Automated linters

You can run the lints that are run on CI locally with:

poetry install --all-extras --with dev
poetry run poe lint
alcarney commented 3 weeks ago

Thanks!

Can you think of anything else that should go into this initial pass at v2? Or shall we make a pre-release to PyPi so people can start trying it out?

tombh commented 3 weeks ago

I can't think of anything right now. We can always make more pre-releases as we need.

Would you like to have a go at making the release using the new doc in https://github.com/openlawlibrary/pygls/pull/488? I'm happy to do it too if you'd prefer.

alcarney commented 3 weeks ago

Sure, I'll give it a go! :)