openlawlibrary / stelae

Preservation, Authentication, Access
GNU Affero General Public License v3.0
7 stars 1 forks source link

misc: small additions to logging; bump `git2` and `rust-version` versions #43

Closed n-dusan closed 3 months ago

n-dusan commented 3 months ago
n-dusan commented 3 months ago

Yes. Does this current tracing span look reasonable?

2024-06-05T17:53:34.643388Z DEBUG HTTP request{http.method=GET http.route=/_api/versions/{path:.*} http.flavor=1.1 http.scheme=http http.host=localhost:8080 http.client_ip=127.0.0.1 http.user_agent=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36 http.target=/_api/versions/ otel.name=HTTP GET /_api/versions/{path:.*} otel.kind="server" request_id=5e030f03-57bd-4b2b-8186-e3871bffde75}:versions{params=Path(Version { publication: None, date: None, compare_date: None, path: Some("") })}: stelae::server::api::versions: Fetching publication versions for '/'

2024-06-05T17:53:34.683477Z DEBUG HTTP request{http.method=GET http.route=/_api/versions/{path:.*} http.flavor=1.1 http.scheme=http http.host=localhost:8080 http.client_ip=127.0.0.1 http.user_agent=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36 http.target=/_api/versions/ otel.name=HTTP GET /_api/versions/{path:.*} otel.kind="server" request_id=5e030f03-57bd-4b2b-8186-e3871bffde75}:versions{params=Path(Version { publication: None, date: None, compare_date: None, path: Some("") })}: stelae::server::api::versions: Found 65 versions
tombh commented 3 months ago

It looks great! I imagine that kind of stuff can be hooked into things like https://sentry.io, or at least I mean it can help you do some powerful debugging.

And I guess you could probably add your own data to it, say the user ID or something.

n-dusan commented 3 months ago

Agreed. I don't know much about how sentry works, but centralized logging has been on my mind for a while now. I'll have some talks to see whether we can get that onto our stelae roadmap.