openlawlibrary / taf

The Archive Framework
GNU Affero General Public License v3.0
10 stars 10 forks source link

fix: use provided url or get remote url #419

Closed balsa-sarenac closed 7 months ago

balsa-sarenac commented 7 months ago

Description (e.g. "Related to ...", etc.)

self.urls is not deterministic between OSs, so on Windows it returns remote repositories last, and on macOS it returns them first. This commit makes it so we don't rely on self.urls.

Also, since the for loop doesn't access or use url variable, I've removed it.

Closes: #372

Code review checklist (for code reviewer to complete)

balsa-sarenac commented 7 months ago

@renatav I've tested locally and it works fine! Thanks for jumping in on this one!