openlawlibrary / taf

The Archive Framework
GNU Affero General Public License v3.0
10 stars 10 forks source link

Fix: Update to repository addition order #442

Closed Rana-KV closed 3 months ago

Rana-KV commented 3 months ago

Description

fixes: #430

Updated the order of adding repository based on target_path if provided, else based on target_name if target_path is empty. Completely making target_name mandatory might break the functionality of updater based repository additions, so did not completely remove the target_path based repository addition.

Updated the --target-name option as required in the CLI. However, I have maintained the default assignment as None because the API function relies on None to determine if the target-name was provided or not.

Code review checklist (for code reviewer to complete)

Rana-KV commented 3 months ago

I have added the --target-name option as required in the CLI. However, I have maintained the default assignment as None because the API function relies on Noneto determine if the target-name was provided or not.

Thanks for catching the problem.