Support Yubikey Manager 5.1.x

openlawlibrary / taf

The Archive Framework

GNU Affero General Public License v3.0

10 stars 7 forks source link

Support Yubikey Manager 5.1.x #444

Closed Rana-KV closed 3 weeks ago

Rana-KV commented 3 weeks ago

Description

fixes: #410

Updated code to support Yubikey Manager 5.1.x
Changes are made to remove deprecated modules and functions and use newer ones.
Dropped support for Yubikey Manager 4.x

Code review checklist (for code reviewer to complete)

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[ ] Title summarizes what is changing
[ ] Commit messages are meaningful (see this for details)
[ ] Tests have been included and/or updated, as appropriate
[ ] Docstrings have been included and/or updated, as appropriate
[ ] Changelog has been updated, as needed (see CHANGELOG.md)

Rana-KV commented 3 weeks ago

I have to update the Changelog document, I want to update it after the review and thought the other PR might have merge conflicts with this one.

Rana-KV commented 3 weeks ago

Thank you for looking into this one, this was a priority for us! I found one small issue, worked following that change. Any idea why it's saying that oll-bot committed this?

I'm sorry, I believe I have mistakenly pushed changes and commit from my test setup, which runs GitHub Actions. One of these actions sets the git config username to oll-bot. I forgot about this configuration and pushed the code.

@renatav, Should I keep this PR or submit a new one?

renatav commented 3 weeks ago

@Rana-KV You can update the commit history and force push to your branch, you don't have to create a new PR. Should not be too difficult. And then just update the changelog and we can get this merged in!

Rana-KV commented 3 weeks ago

@renatav, Thanks I have did the needed changes.