search

openlawlibrary / taf

The Archive Framework
GNU Affero General Public License v3.0
10 stars 10 forks source link

If top-level auth repo is unchanged, `taf repo update` doesn't update dependencies #520

Closed n-dusan closed 2 months ago

n-dusan commented 2 months ago

Taf repo update needs to update dependent auth repos, even if top level did not change

renatav commented 2 months ago

This was not a design decision, the dependencies are supposed to be updated even if the parent repo was not updated, as long as it's update didn't fail (even if the update was partial). I haven't really thought about what should happen in case of a partial update, although that is not related to this issues. This is what this code looks like: https://github.com/openlawlibrary/taf/blob/5e54b8e07b411b00d055766585e063de29b896b2/taf/updater/updater.py#L451

So, if the updater is skipping the update of these child repositories, it means that either there is something wrong with the --no-deps flag, or th update data is not getting set properly. I think that this would be a good issue for someone learning the updater to tackle. The test can be created pretty easily too by modifying one of the update tests involving repos with repositories. I would say that this is a good first issue, but the simplest issue that can be related to the update process

renatav commented 2 months ago

Resolved by merging #528