search

openlawteam / ethers-gcp-kms-signer

Ethers.js Signer that connects to GCP KMS
https://www.npmjs.com/package/ethers-gcp-kms-signer
MIT License
38 stars 22 forks source link

Not working in TypeScript project #3

Closed johanneskares closed 2 years ago

johanneskares commented 2 years ago

Thanks for the repo, great work!

I'm having trouble getting it to work in a TypeScript project.

I installed both npm i ethers-gcp-kms-signer and npm i ethers-aws-kms-signer for reference.

Minimal code example here:

index.ts

import {AwsKmsSigner} from "ethers-aws-kms-signer";
import {GcpKmsSigner} from "ethers-gcp-kms-signer";

When compiling I get: Could not find a declaration file for module 'ethers-gcp-kms-signer'. '/Users/johanneskares/Programming/firebase-test/functions/node_modules/ethers-gcp-kms-signer/dist/signer.js' implicitly has an 'any' type.

When I just use ethers-aws-kms-signer I can compile. Unfortunately I don't know much about how NPM packages work internally, so can't really help much.

Also, can be tried out here:

johanneskares commented 2 years ago

I created a fix for this issue:

https://github.com/openlawteam/ethers-gcp-kms-signer/pull/4

fforbeck commented 2 years ago

new release with your fix is out: https://github.com/openlawteam/ethers-gcp-kms-signer/releases/tag/v1.1.2

Thanks again!