openlawteam / tribute-contracts

A new modular DAO framework, inspired by the Moloch smart contracts
https://tributedao.com
MIT License
297 stars 110 forks source link

feat: configuration adapter supports addr conf (#425) #432

Closed fforbeck closed 3 years ago

fforbeck commented 3 years ago

Proposed Changes

Closes #331

codecov[bot] commented 3 years ago

Codecov Report

Merging #432 (15fe7ff) into master (229702d) will increase coverage by 0.06%. The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   80.83%   80.90%   +0.06%     
==========================================
  Files          47       47              
  Lines        1654     1660       +6     
  Branches      388      390       +2     
==========================================
+ Hits         1337     1343       +6     
  Misses        317      317              
Impacted Files Coverage Δ
...ntracts/adapters/voting/KickBadReporterAdapter.sol 0.00% <0.00%> (ø)
contracts/adapters/voting/OffchainVotingHash.sol 40.00% <0.00%> (ø)
contracts/extensions/erc1271/ERC1271.sol 100.00% <ø> (ø)
contracts/extensions/executor/Executor.sol 100.00% <ø> (ø)
contracts/extensions/nft/NFT.sol 82.35% <ø> (ø)
contracts/utils/DaoArtifacts.sol 100.00% <ø> (ø)
contracts/adapters/BankAdapter.sol 66.66% <50.00%> (ø)
...racts/extensions/erc1155/ERC1155TokenExtension.sol 74.32% <50.00%> (ø)
contracts/adapters/voting/OffchainVoting.sol 39.19% <58.33%> (ø)
...cts/extensions/token/erc20/ERC20TokenExtension.sol 83.78% <75.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 229702d...15fe7ff. Read the comment docs.